It is not possible to create a relationship with a password protected template #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lready allocated by the active identity
NikolaVetnic
approved these changes
Oct 14, 2024
tnotheis
deleted the
it-is-not-possible-to-create-a-relationship-with-a-password-protected-template
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
The important changes are in RelationshipTemplate.cs. There have been two bugs:
IsAllocatedBywas inverted. Obviously, a template is considered "allocated" by a specific identity if there is an allocation for that identity.CanBeCollectedUsingPassword, I allowed identities that have already allocated the template to collect it again without a password.The other two files are related to tests for the
CanBeCollectedUsingPasswordmethod.